[webkit-reviews] review denied: [Bug 203548] [FTW] Adopt DirectWrite in place of Uniscribe : [Attachment 382204] Patch v2

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 203548: [FTW] Adopt DirectWrite in place of Uniscribe
https://bugs.webkit.org/show_bug.cgi?id=203548

Attachment 382204: Patch v2

https://bugs.webkit.org/attachment.cgi?id=382204&action=review




--- Comment #14 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 382204
  --> https://bugs.webkit.org/attachment.cgi?id=382204
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=382204&action=review

> Source/WebCore/platform/graphics/ComplexTextController.cpp:154
> +#if PLATFORM(WIN) && !USE(DIRECT2D)

This line can be removed because this is in #else of line #46 condition.

> Source/WebCore/platform/graphics/FontPlatformData.h:242
> +    COMPtr<IDWriteFontCollection1> m_dwFontCollection;

You added 'm_dwFontCollection', but not used in this patch. Remove it until it
is really needed?

> Source/WebCore/platform/graphics/win/ComplexTextControllerDirectWrite.cpp:80
> +    localeName[localeLength] = 0;

I think this line is not needed. See Comment 5.