[webkit-reviews] review granted: [Bug 203472] [Quick Look] Clean up LegacyPreviewLoaderClients : [Attachment 382230] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 203472: [Quick Look] Clean up LegacyPreviewLoaderClients
https://bugs.webkit.org/show_bug.cgi?id=203472

Attachment 382230: Patch

https://bugs.webkit.org/attachment.cgi?id=382230&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 382230
  --> https://bugs.webkit.org/attachment.cgi?id=382230
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382230&action=review

> Source/WebKit/Platform/SharedMemory.cpp:35
> +RefPtr<SharedMemory> SharedMemory::create(const SharedBuffer& buffer)

I was a little confused here, trying to figure out how you could make an
existing become "shared memory"

I'd like the name to be more clear that the new SharedMemory object is a copy.

Maybe "createWithCopy" or something explicit like that.

> Source/WebKit/Platform/SharedMemory.h:104
>      static RefPtr<SharedMemory> create(void*, size_t, Protection);
> +    static RefPtr<SharedMemory> create(const WebCore::SharedBuffer&);

I know the existence of this one is just as confusing. I would've made the same
comment when it was added. (Unless, of course,I am the one who added it)