[webkit-reviews] review granted: [Bug 202676] [JSC] Add fast path for String#localeCompare : [Attachment 382215] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 202676: [JSC] Add fast path for String#localeCompare
https://bugs.webkit.org/show_bug.cgi?id=202676

Attachment 382215: Patch

https://bugs.webkit.org/attachment.cgi?id=382215&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 382215
  --> https://bugs.webkit.org/attachment.cgi?id=382215
Patch

r=me.  Do we already have test cases for 8bit vs 8bit, 16 bit vs 16bit, 8bit vs
16bit, and 16bit vs 8bit localeCompare?  If not, can you add this test to make
sure there's no bug introduced here?  Also an API test to verify that
StringView::isAllASCII() is working would also be nice.  Thanks.