[webkit-reviews] review granted: [Bug 203400] [JSC] Remove JSPromiseDeferred : [Attachment 381995] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 203400: [JSC] Remove JSPromiseDeferred
https://bugs.webkit.org/show_bug.cgi?id=203400

Attachment 381995: Patch

https://bugs.webkit.org/attachment.cgi?id=381995&action=review




--- Comment #18 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 381995
  --> https://bugs.webkit.org/attachment.cgi?id=381995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381995&action=review

r=me but I think the functionality you marked as deprecated is public API so we
can't get rid of it. Can we remove the deprecated API naming?

> Source/JavaScriptCore/runtime/Completion.cpp:197
>      scope.releaseAssertNoException();

This seems wrong.

> Source/JavaScriptCore/runtime/JSPromise.h:67
> +    // Deprecated APIs. Remove it once SPIs are removed.

I think we have shipped this API, I don't think we can remove it.