[webkit-reviews] review granted: [Bug 203521] Fix a bug that cannot unhide a platform. : [Attachment 382107] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 203521: Fix a bug that cannot unhide a platform.
https://bugs.webkit.org/show_bug.cgi?id=203521

Attachment 382107: Patch

https://bugs.webkit.org/attachment.cgi?id=382107&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 382107
  --> https://bugs.webkit.org/attachment.cgi?id=382107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382107&action=review

> Websites/perf.webkit.org/public/admin/platforms.php:62
> -	       || update_field('platforms', 'platform', 'hidden'))
> +	       || update_field('platforms', 'platform', 'hidden',
Database::to_database_boolean(array_get($_POST, 'hidden'))))

Can we add a helper function like update_boolean_field and do this work there?
It's kind of silly to specify the updated field name twice.