[webkit-reviews] review granted: [Bug 201731] [SVG2] fill-opacity, stroke-opacity, stop-opacity and flood-opacity doe not support percentage : [Attachment 382098] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 201731: [SVG2] fill-opacity, stroke-opacity, stop-opacity and flood-opacity
doe not support percentage
https://bugs.webkit.org/show_bug.cgi?id=201731

Attachment 382098: Patch

https://bugs.webkit.org/attachment.cgi?id=382098&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 382098
  --> https://bugs.webkit.org/attachment.cgi?id=382098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382098&action=review

> Source/WebCore/ChangeLog:16
> +	   Tests: fast/css/parsing-opacity.html
> +		  fast/svg/parsing-fill-opacity.html
> +		  fast/svg/parsing-flood-opacity.html
> +		  fast/svg/parsing-stop-opacity.html
> +		  fast/svg/parsing-stroke-opacity.html

These should be WPT, if there isn't already WPT coverage.

> LayoutTests/fast/css/parsing-opacity.html:62
> +testInner("opacity", "0", "0");
> +testInner("opacity", "0.5", "0.5");
> +testInner("opacity", "1", "1");
> +testInner("opacity", "1000", "1000");
> +testInner("opacity", "-400", "-400");
> +testInner("opacity", "20%", "20%");
> +testInner("opacity", "-600%", "-600%");
> +testInner("opacity", "700%", "700%");
> +testComputed("opacity", "0", "0");
> +testComputed("opacity", "0.5", "0.5");
> +testComputed("opacity", "1", "1");
> +testComputed("opacity", "1000", "1");
> +testComputed("opacity", "-400", "0");
> +testComputed("opacity", "25%", "0.25");
> +testComputed("opacity", "-600%", "0");
> +testComputed("opacity", "700%", "1");
> +negativeTest("opacity", "2px");
> +negativeTest("opacity", "auto");
> +negativeTest("opacity", "none");
> +negativeTest("opacity", "'str'");

How about 100.2% and 2.5E2 values and %?