[webkit-reviews] review granted: [Bug 203496] Expose _printOperationWithPrintInfo: SPI as API : [Attachment 382086] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 28 11:44:02 PDT 2019


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 203496: Expose _printOperationWithPrintInfo: SPI as API
https://bugs.webkit.org/show_bug.cgi?id=203496

Attachment 382086: Patch

https://bugs.webkit.org/attachment.cgi?id=382086&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 382086
  --> https://bugs.webkit.org/attachment.cgi?id=382086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382086&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:307
> +/* @abstract Returns an NSPrintOperation object configured to print the
contents of this WKWebView
> + at param printInfo The print info object used to configure the resulting print
operation.
> +*/
> +- (NSPrintOperation *)printOperationWithPrintInfo:(NSPrintInfo *)printInfo
WK_API_AVAILABLE(macos(WK_MAC_TBA));
> +

Should this be part of one of the !TARGET_OS_IPHONE sections either above or
below?


More information about the webkit-reviews mailing list