[webkit-reviews] review granted: [Bug 203440] Add bindings support for the enterkeyhint HTML attribute : [Attachment 382069] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 203440: Add bindings support for the enterkeyhint HTML attribute
https://bugs.webkit.org/show_bug.cgi?id=203440

Attachment 382069: Patch

https://bugs.webkit.org/attachment.cgi?id=382069&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 382069
  --> https://bugs.webkit.org/attachment.cgi?id=382069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382069&action=review

> Source/WebCore/html/EnterKeyHint.cpp:35
> +static const AtomString& enterKeyHintNameEnter()
> +{
> +    static NeverDestroyed<AtomString> name("enter",
AtomString::ConstructFromLiteral);

I don't think these strings should be AtomString.
We're always doing case insensitive comparison, and we're just returning for
IDL.
There is virtually no benefit for these rarely used strings to be AtomString.

> Source/WebCore/html/HTMLElement.idl:68
> +    attribute DOMString enterKeyHint;

We need a runtime flag for this.
e.g. I don't think it would be supported on any port but Apple's mobile ports,
right?
Does desktop version of Chrome support this attribute as well?