[webkit-reviews] review granted: [Bug 203464] Fix nth-child An+B serialization to match the spec : [Attachment 382023] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203464: Fix nth-child An+B serialization to match the spec
https://bugs.webkit.org/show_bug.cgi?id=203464

Attachment 382023: Patch

https://bugs.webkit.org/attachment.cgi?id=382023&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 382023
  --> https://bugs.webkit.org/attachment.cgi?id=382023
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382023&action=review

Astonishing amount of test coverage for something of so little significance!

> Source/WebCore/css/CSSSelector.cpp:393
> +{

'str' is not a great name (yes, that's what the existing code uses).