[webkit-reviews] review granted: [Bug 139359] [GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky : [Attachment 380683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 25 15:39:58 PDT 2019


Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 139359: [GTK] Layout test
inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html
is flaky
https://bugs.webkit.org/show_bug.cgi?id=139359

Attachment 380683: Patch

https://bugs.webkit.org/attachment.cgi?id=380683&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 380683
  --> https://bugs.webkit.org/attachment.cgi?id=380683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380683&action=review

rs=me, but please run it through EWS one more time since it looks like there
were some (possibly unrelated) failures on mac-debug-wk1

>
LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.h
tml:99
> +			   setTimeout(function (responseObject) {

What about this?
```
    InspectorProtocol.awaitEvent({event: "Debugger.resumed"}).then(() => {
	ProtocolTest.log("Resumed from breakpoint");
	ProtocolTest.log("Test complete");
	ProtocolTest.completeTest();
    });
    InspectorProtocol.sendCommand("Debugger.resume");
```


More information about the webkit-reviews mailing list