[webkit-reviews] review granted: [Bug 203398] Add exclusion rules to text manipulation SPI : [Attachment 381889] Yet another unified build fixes

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 203398: Add exclusion rules to text manipulation SPI
https://bugs.webkit.org/show_bug.cgi?id=203398

Attachment 381889: Yet another unified build fixes

https://bugs.webkit.org/attachment.cgi?id=381889&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 381889
  --> https://bugs.webkit.org/attachment.cgi?id=381889
Yet another unified build fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=381889&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.h:35
> + at property (nonatomic) BOOL isExcluded;

Nit - in ObjC API, boolean properties like this are usually written with an
“is”-prefixed getter and a property name without the ”is”. E.g.:

@property (nonatomic, getter=isExcluded) BOOL excluded;

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:184
> +	   [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES
forElement:@"code"],

Nit - these _WKTextManipulationExclusionRules will all leak (but maybe that’s
fine for an API test since the process is recreated every time?)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:221
> +	   [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES
forAttribute:@"data-exclude" value:@"yes"],
> +	   [[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO
forAttribute:@"data-exclude" value:@"no"],

(Ditto)