[webkit-reviews] review granted: [Bug 201956] Python 3: Add support in webkitpy.common.checkout : [Attachment 381945] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 201956: Python 3: Add support in webkitpy.common.checkout
https://bugs.webkit.org/show_bug.cgi?id=201956

Attachment 381945: Patch

https://bugs.webkit.org/attachment.cgi?id=381945&action=review




--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 381945
  --> https://bugs.webkit.org/attachment.cgi?id=381945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381945&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:84
> +    def __hash__(self):
> +	   result = hash(self.full_name)
> +	   for email in self._case_preserved_emails:
> +	       result ^= hash(email)
> +	   return result

Discussed with Jonathan in person, we think we should use all fields used in
__eq__ to compute hash.