[webkit-reviews] review granted: [Bug 203396] [Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface : [Attachment 381880] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 25 10:32:39 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 203396: [Quick Look] Move the QLPreviewConverter delegate into
PreviewConverter and vend a C++ client interface
https://bugs.webkit.org/show_bug.cgi?id=203396

Attachment 381880: Patch

https://bugs.webkit.org/attachment.cgi?id=381880&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 381880
  --> https://bugs.webkit.org/attachment.cgi?id=381880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381880&action=review

> Source/WTF/wtf/FeatureDefines.h:222
> +#if PLATFORM(IOS)
> +#define ENABLE_PREVIEW_CONVERTER 1

No IOS_FAMILY?	This seems correct, but I'm double checking.


More information about the webkit-reviews mailing list