[webkit-reviews] review granted: [Bug 203383] Add more information to SRI failure console messages : [Attachment 381861] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 203383: Add more information to SRI failure console messages
https://bugs.webkit.org/show_bug.cgi?id=203383

Attachment 381861: Patch

https://bugs.webkit.org/attachment.cgi?id=381861&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 381861
  --> https://bugs.webkit.org/attachment.cgi?id=381861
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381861&action=review

> Source/WebCore/loader/SubresourceIntegrity.cpp:216
> +    builder.append(". Failed integrity metadata check. ");

appendLiteral

> Source/WebCore/loader/SubresourceIntegrity.cpp:217
> +    builder.append("Content length: ");

appendLiteral

> Source/WebCore/loader/SubresourceIntegrity.cpp:221
> +	   builder.append("(no content)");

appendLiteral

> Source/WebCore/loader/SubresourceIntegrity.cpp:222
> +    builder.append(", Expected content length: ");

appendLiteral

> Source/WebCore/loader/SubresourceIntegrity.cpp:224
> +    builder.append(", Expected metadata: ");

appendLiteral

> Source/WebCore/loader/SubresourceIntegrity.cpp:225
> +    builder.append(integrityMetadata);

appendLiteral