[webkit-reviews] review granted: [Bug 203290] REGRESSION(r251468): Build, test failures in 32-bit JSC after BytecodeIndex refactoring : [Attachment 381796] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 203290: REGRESSION(r251468): Build, test failures in 32-bit JSC after
BytecodeIndex refactoring
https://bugs.webkit.org/show_bug.cgi?id=203290

Attachment 381796: Patch

https://bugs.webkit.org/attachment.cgi?id=381796&action=review




--- Comment #18 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 381796
  --> https://bugs.webkit.org/attachment.cgi?id=381796
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381796&action=review

r=me weird that this worked on 64 bit... since I would have guessed this would
break a lot of things...

>> Source/JavaScriptCore/bytecode/BytecodeIndex.h:42
>> +	}
> 
> This missing constructor was the main problem of the remaining issues.
Without it, the BytecodeIndex(WTF::HashTableDeletedValue) construction
defaulted to the uin32_t constructor. With WTF::HashTableDeletedValue being
effectively 0, this ended up constructing zero-valued BytecodeIndex objects
that on their own are completely valid, non-empty and non-deleted.

Ugh, we should make WTF::HashTableDeletedValueType be a enum class...