[webkit-reviews] review granted: [Bug 203238] [Web Animations] Only process CSS properties affected by a given CSS transition : [Attachment 381793] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 08:49:54 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 203238: [Web Animations] Only process CSS properties affected by a given
CSS transition
https://bugs.webkit.org/show_bug.cgi?id=203238

Attachment 381793: Patch

https://bugs.webkit.org/attachment.cgi?id=381793&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381793
  --> https://bugs.webkit.org/attachment.cgi?id=381793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381793&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:379
> +void AnimationTimeline::updateCSSTransitionsForElementAndProperty(Element&
element, CSSPropertyID property, const RenderStyle& currentStyle, const
RenderStyle& afterChangeStyle, AnimationTimeline::PropertyToTransitionMap&
runningTransitionsByProperty, PropertyToTransitionMap&
completedTransitionsByProperty, const MonotonicTime& generationTime)

You can pass MonotonicTime by value (it has sizeof(double)).

> Source/WebCore/animation/AnimationTimeline.cpp:535
>	   }

I would return here and remove the else.


More information about the webkit-reviews mailing list