[webkit-reviews] review granted: [Bug 203286] Add a mechanism to find and manipulate text by paragraphs : [Attachment 381774] iOS build fix

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 203286: Add a mechanism to find and manipulate text by paragraphs
https://bugs.webkit.org/show_bug.cgi?id=203286

Attachment 381774: iOS build fix

https://bugs.webkit.org/attachment.cgi?id=381774&action=review




--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 381774
  --> https://bugs.webkit.org/attachment.cgi?id=381774
iOS build fix

View in context: https://bugs.webkit.org/attachment.cgi?id=381774&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationDelegate.h:30
> + at class _WKFrameHandle;

Nit - do you need this forward declaration?

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:27
> +#include "config.h"
> +#include "_WKTextManipulationItem.h"

Nit - #include => #import

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm:27
> +#include "config.h"
> +#include "_WKTextManipulationToken.h"

Nit - #include => #import

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm:29
> +#import <wtf/RetainPtr.h>

Nit - Is this #import needed? I don’t see RetainPtr being used in this file.

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm:38
> +- (instancetype)init
> +{
> +    if (!(self = [super init]))
> +	   return nil;
> +    return self;
> +}

Nit - I’m not sure you need to override and implement -init here, since it’s
not doing anything special.