[webkit-reviews] review granted: [Bug 203291] [Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests : [Attachment 381791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 05:25:45 PDT 2019


youenn fablet <youennf at gmail.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 203291: [Web Animations] Update WPT tests related to Web Animations and
remove imported Mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=203291

Attachment 381791: Patch

https://bugs.webkit.org/attachment.cgi?id=381791&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 381791
  --> https://bugs.webkit.org/attachment.cgi?id=381791
Patch

r=me.
It might be nice to update TestExpectations quickly to skip some timing out
tests.
Also some tests are apparently taking very long to pass. I wonder whether bots
will like them.

View in context: https://bugs.webkit.org/attachment.cgi?id=381791&action=review

>
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-m
arker-pseudoelement-expected.txt:4
> +TIMEOUT AnimationEvent should have the correct pseudoElement memeber Test
timed out

Let's skip this one

>
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/non-rendered-el
ement-002-expected.txt:5
> +NOTRUN Transitions on ::marker pseudo-elements are canceled when the parent
display type is no longer list-item 

Let's skip this one

>
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-valu
e-001.html:50
> +	       var timeout = 60000;

Are we sure we want to run this test?

>
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-valu
e-002.html:52
> +	       var timeout = 60000;

Ditto.


More information about the webkit-reviews mailing list