[webkit-reviews] review granted: [Bug 201727] ImageDecoders: use a thread safe data buffer for Cairo backing store : [Attachment 378659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 00:54:59 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 201727: ImageDecoders: use a thread safe data buffer for Cairo backing
store
https://bugs.webkit.org/show_bug.cgi?id=201727

Attachment 378659: Patch

https://bugs.webkit.org/attachment.cgi?id=378659&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 378659
  --> https://bugs.webkit.org/attachment.cgi?id=378659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378659&action=review

> Source/WebCore/platform/graphics/ImageBackingStore.h:188
> +    class ThreadSafeRGBAPixelBuffer : public
ThreadSafeRefCounted<ThreadSafeRGBAPixelBuffer> {

As I suggested in the comments I would rename this, because this name is
confusing.


More information about the webkit-reviews mailing list