[webkit-reviews] review granted: [Bug 203285] [JSC] Figure out missing prepareCallOperation : [Attachment 381749] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 203285: [JSC] Figure out missing prepareCallOperation
https://bugs.webkit.org/show_bug.cgi?id=203285

Attachment 381749: Patch

https://bugs.webkit.org/attachment.cgi?id=381749&action=review




--- Comment #13 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 381749
  --> https://bugs.webkit.org/attachment.cgi?id=381749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381749&action=review

r=me

> Source/JavaScriptCore/interpreter/FrameTracers.h:120
> +	   // When debugging mode, USE(BUILTIN_FRAME_ADDRESS) environment also
puts frame pointer to vm.topCallFrame.
> +	   // And we can ensure it is working by comparing with the result of
__builtin_frame_adress.

I suggest rephrasing this as:

If !ASSERT_DISABLED and USE(BUILTIN_FRAME_ADDRESS), prepareCallOperation() will
put the frame pointer into vm.topCallFrame. We can ensure here that a call to
prepareCallOperation() (or its equivalent) is not missing by comparing
vm.topCallFrame to the result of __builtin_frame_address which is passed in as
callFrame.