[webkit-reviews] review granted: [Bug 199417] [EWS] Multiple builds are triggered for one patch sometimes in new EWS : [Attachment 381715] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 199417: [EWS] Multiple builds are triggered for one patch sometimes in new
EWS
https://bugs.webkit.org/show_bug.cgi?id=199417

Attachment 381715: Patch

https://bugs.webkit.org/attachment.cgi?id=381715&action=review




--- Comment #11 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 381715
  --> https://bugs.webkit.org/attachment.cgi?id=381715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381715&action=review

>>> Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:63
>>> +	     _log.info('{} r? patches, {} patches need to be sent to Buildbot:
{}'.format(len(patch_ids), len(patches_to_send), patches_to_send))
>> 
>> What are 'patches_to_send' and what do they look like when printed?
> 
> patches_to_send is a list of r? patch_ids which needs EWS processing. 
> 
> This is just a log improvement. This is how the log looks like after this
change:
> 29 r? patches, 2 patches need to be sent to Buildbot: [381699, 381700]

Got it, so when we print patches, its just the patch IDs.