[webkit-reviews] review granted: [Bug 203278] [SVG2] Fix SVGSVGElement to conform with SVG2 : [Attachment 381638] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 203278: [SVG2] Fix SVGSVGElement to conform with SVG2
https://bugs.webkit.org/show_bug.cgi?id=203278

Attachment 381638: Patch

https://bugs.webkit.org/attachment.cgi?id=381638&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381638
  --> https://bugs.webkit.org/attachment.cgi?id=381638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381638&action=review

> Source/WebCore/svg/SVGSVGElement.cpp:266
> +    element.document().updateLayoutIgnorePendingStylesheets();

You can't call updateLayoutIgnorePendingStylesheets() and guarantee that the
element is still valid. This function should keep a Ref<SVGElement> around.

> Source/WebCore/svg/SVGSVGElement.cpp:272
> +    element.document().updateLayoutIgnorePendingStylesheets();

Ditto.