[webkit-reviews] review granted: [Bug 203091] FetchRequest should not prevent entering the back/forward cache : [Attachment 381687] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203091: FetchRequest should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203091

Attachment 381687: Patch

https://bugs.webkit.org/attachment.cgi?id=381687&action=review




--- Comment #20 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 381687
  --> https://bugs.webkit.org/attachment.cgi?id=381687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381687&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:299
> +    runNetworkTaskWhenPossible([this, protectedThis =
makePendingActivity(*this)]() mutable {

Can We makePendingActivity in runNetworkTaskWhenPossible in the
postTask/queueTask case only.
In most cases, we do not need to ref/unref unnecessarily.

>
LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsReadableStre
am.html:36
> +    readableStream.getReader().read().then(() => {

Can we read the stream and validate that data is correct?
The validateStreamFromString routine from
LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js can be
used almost as is (modulo assert_ -> shouldBe).

>
LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsText.html:34
> +    request.text().then(() => {

Can we check the text promise value?
Something like: request.text().then((text) => { shouldBe(text, textData)