[webkit-reviews] review granted: [Bug 202838] String.prototype.matchAll should throw on non-global regex : [Attachment 380717] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 202838: String.prototype.matchAll should throw on non-global regex
https://bugs.webkit.org/show_bug.cgi?id=202838

Attachment 380717: Patch

https://bugs.webkit.org/attachment.cgi?id=380717&action=review




--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 380717
  --> https://bugs.webkit.org/attachment.cgi?id=380717
Patch

seems reasonable. I'm assuming the `matchAll()` entry code is not a perf
bottleneck and the real work happens inside the `regExp. at matchAllSymbol()`
call?