[webkit-reviews] review granted: [Bug 202563] [WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] : [Attachment 381659] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 202563: [WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate
_webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=202563

Attachment 381659: Patch

https://bugs.webkit.org/attachment.cgi?id=381659&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 381659
  --> https://bugs.webkit.org/attachment.cgi?id=381659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381659&action=review

I have some minor suggestions, but overall looks good! r=me

>
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
74
> +	   }, [&](const  ExceptionData& exception) {

It looks like you have two spaces between 'const' and 'ExceptionData&'.

> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:47
> +void WebAuthenticatorCoordinator::makeCredential(const Frame& frame, const
SecurityOrigin& origin, const Vector<uint8_t>& hash, const
PublicKeyCredentialCreationOptions& options, RequestCompletionHandler&&
handler)

Since origin and hash are coming from the message passing, I wonder if they
could be WTFMove'd? Surely the hash would be worth moving.