[webkit-reviews] review granted: [Bug 202561] [WebAuthn] Add more information to _WKWebAuthenticationPanel : [Attachment 381658] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 202561: [WebAuthn] Add more information to _WKWebAuthenticationPanel
https://bugs.webkit.org/show_bug.cgi?id=202561

Attachment 381658: Patch

https://bugs.webkit.org/attachment.cgi?id=381658&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 381658
  --> https://bugs.webkit.org/attachment.cgi?id=381658
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381658&action=review

> Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp:53
> +	   m_transports.append(AuthenticatorTransport::Usb);

uncheckedAppend if we have m_transports.reserveInitialCapacity

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:321
> +    page->uiClient().runWebAuthenticationPanel(*page, panel, [transports =
WTFMove(transports), weakPanel = makeWeakPtr(panel), weakThis =
makeWeakPtr(*this), this] (WebAuthenticationPanelResult result) {

Do we need to capture transports since we have weakPanel that stores roughly
the same information?

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:358
> +	   processGoogleLegacyAppIdSupportExtension(options.extensions,
transports);
> +    }, [&](const  PublicKeyCredentialRequestOptions& options) {

s/  / /

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:87
> +    virtual void respondReceivedInternal(Respond&&) { };

s/;//