[webkit-reviews] review granted: [Bug 203291] [Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests : [Attachment 381673] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 03:34:01 PDT 2019


youenn fablet <youennf at gmail.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 203291: [Web Animations] Update WPT tests related to Web Animations and
remove imported Mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=203291

Attachment 381673: Patch

https://bugs.webkit.org/attachment.cgi?id=381673&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 381673
  --> https://bugs.webkit.org/attachment.cgi?id=381673
Patch

r=me once bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=381673&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +	   *
web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentati
ve-expected.txt: Renamed from
LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing-expe
cted.txt.

If you feel like, you can add a one-liner like:
* web-platform-tests/css/css-animations: resynced.

> LayoutTests/TestExpectations:3883
> +webkit.org/b/XXXXXX
imported/w3c/web-platform-tests/css/css-animations/keyframes-remove-documentEle
ment-crash.html [ Timeout ]

File a bug?
If it is timing out, let's skip it for now.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animationevent-i
nterface.html:7
> +<script src="../../../../../resources/testharnessreport.js"></script>

These changes are unnecessary.
Maybe this is due to the way you are running the script.
You can use --no-links-conversion to remove these changes.


More information about the webkit-reviews mailing list