[webkit-reviews] review granted: [Bug 203284] Change some image-related CSSValue subclasses to use references : [Attachment 381647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 22 21:21:48 PDT 2019


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203284: Change some image-related CSSValue subclasses to use references
https://bugs.webkit.org/show_bug.cgi?id=203284

Attachment 381647: Patch

https://bugs.webkit.org/attachment.cgi?id=381647&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 381647
  --> https://bugs.webkit.org/attachment.cgi?id=381647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381647&action=review

> Source/WebCore/css/CSSFilterImageValue.cpp:101
> +RefPtr<Image> CSSFilterImageValue::image(RenderElement& renderer, const
FloatSize& size)

This could most likely be a const RenderElement&


More information about the webkit-reviews mailing list