[webkit-reviews] review granted: [Bug 203213] Python 3: 2to3 script may not be in a user's path : [Attachment 381464] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 203213: Python 3: 2to3 script may not be in a user's path
https://bugs.webkit.org/show_bug.cgi?id=203213

Attachment 381464: Patch

https://bugs.webkit.org/attachment.cgi?id=381464&action=review




--- Comment #2 from dewei_zhu at apple.com ---
Comment on attachment 381464
  --> https://bugs.webkit.org/attachment.cgi?id=381464
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381464&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:-221
> -	       self._executive.run_command(['2to3', '-w',
self._fs.join(_AUTOINSTALLED_DIR, 'bs4')])

It may be cleaner if we invoke 
self._executive.run_command([os.path.join(os.path.dirname(lib2to3),
"__main__.py"), '-w', self._fs.join(_AUTOINSTALLED_DIR, 'bs4')])
This way, we don't have to temporarily change sys.stdout and use
mulitiprocessing module.