[webkit-reviews] review denied: [Bug 203238] [Web Animations] Only process CSS properties affected by a given CSS transition : [Attachment 381524] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 203238: [Web Animations] Only process CSS properties affected by a given
CSS transition
https://bugs.webkit.org/show_bug.cgi?id=203238

Attachment 381524: Patch

https://bugs.webkit.org/attachment.cgi?id=381524&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381524
  --> https://bugs.webkit.org/attachment.cgi?id=381524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381524&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:497
> +    auto compileTransitionPropertiesInStyle = [&](const RenderStyle& style)
{

This is already a long function. I think you should move this and
processProperty into real functions.