[webkit-reviews] review denied: [Bug 203074] Make it possible to not include IPC Messages headers in other headers : [Attachment 381522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 22 07:07:40 PDT 2019


Alex Christensen <achristensen at apple.com> has denied Tim Horton
<thorton at apple.com>'s request for review:
Bug 203074: Make it possible to not include IPC Messages headers in other
headers
https://bugs.webkit.org/show_bug.cgi?id=203074

Attachment 381522: Patch

https://bugs.webkit.org/attachment.cgi?id=381522&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 381522
  --> https://bugs.webkit.org/attachment.cgi?id=381522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381522&action=review

>> Source/WebKit/Scripts/webkit/LegacyMessages-expected.h:364
>> +	using DelayedReply = GetPluginProcessConnectionDelayedReply;	static
void send(std::unique_ptr<IPC::Encoder>&&, IPC::Connection&, const
IPC::Connection::Handle& connectionHandle);
> 
> This is a bug

Hooray tests!


More information about the webkit-reviews mailing list