[webkit-reviews] review granted: [Bug 203201] [GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build : [Attachment 381430] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 203201: [GTK] Web Inspector: add an option for disabling minification and
concatenation of inspector UI in release build
https://bugs.webkit.org/show_bug.cgi?id=203201

Attachment 381430: Patch

https://bugs.webkit.org/attachment.cgi?id=381430&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 381430
  --> https://bugs.webkit.org/attachment.cgi?id=381430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381430&action=review

> Source/WebKit/InspectorGResources.cmake:52
> +	   elseif (DEVELOPER_MODE)
> +	       set(COMBINE_INSPECTOR_RESOURCES YES)

Now that inspector and test resources are split we don't need this branch.

> Source/WebKit/InspectorGResources.cmake:61
> +	   if (CMAKE_BUILD_TYPE STREQUAL "Debug")
> +	       set(COMBINE_TEST_RESOURCES YES)
> +	   elseif (DEVELOPER_MODE)
> +	       set(COMBINE_TEST_RESOURCES YES)

And here we could use OR