[webkit-reviews] review granted: [Bug 203181] imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https.html is flaky : [Attachment 381447] Fix GTK/WPE builds

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 203181:
imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-basics
.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203181

Attachment 381447: Fix GTK/WPE builds

https://bugs.webkit.org/attachment.cgi?id=381447&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 381447
  --> https://bugs.webkit.org/attachment.cgi?id=381447
Fix GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=381447&action=review

Since change count is a Cocoa specific concept, we need to hide that from the
platform agnostic code. Perhaps something like PasteboardToken.

> Source/WebCore/Modules/async-clipboard/Clipboard.h:70
> -	   int changeCount;
> +	   long changeCount;

Can we use uint32_t or uint64_t to be more explicit about the width of this
count?
Also, changeCount is cocoa specific concept.
It probably doesn't belong in this platform agnostic class not that we should
fix it in this patch.

> Source/WebCore/platform/Pasteboard.h:325
> +    long m_changeCount { 0 };
> +

I don't think this change makes sense. The concept of change count doesn't
exist in platforms like Windows.