[webkit-reviews] review granted: [Bug 203186] Suspend in dedicated worker threads while in the back/forward cache : [Attachment 381458] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203186: Suspend in dedicated worker threads while in the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203186

Attachment 381458: Patch

https://bugs.webkit.org/attachment.cgi?id=381458&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 381458
  --> https://bugs.webkit.org/attachment.cgi?id=381458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381458&action=review

> Source/WebCore/workers/Worker.h:102
> +    bool isSuspendedForBackForwardCache { false };

Maybe put this after m_shouldBypassMainWorldContentSecurityPolicy to pack
better?

> Source/WebCore/workers/WorkerGlobalScopeProxy.h:57
> +    // Back / Forward cache support.
> +    virtual void suspend() = 0;
> +    virtual void resume() = 0;

Why don't we just call them suspendForBackForwardCache &
resumeForBackForwardCache instead of adding a comment?

> Source/WebCore/workers/WorkerThread.h:141
> +    Lock m_suspensionLock;
> +    Condition m_suspensionCondition;

Use BinarySemaphore instead?