[webkit-reviews] review granted: [Bug 169667] URL: protocol setter needs to be more restrictive around file : [Attachment 381413] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 21 13:35:00 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 169667: URL: protocol setter needs to be more restrictive around file
https://bugs.webkit.org/show_bug.cgi?id=169667
Attachment 381413: Patch
https://bugs.webkit.org/attachment.cgi?id=381413&action=review
--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 381413
--> https://bugs.webkit.org/attachment.cgi?id=381413
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=381413&action=review
> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:154
> + fprintf(stderr,
"InjectedBundle::overrideBoolPreferenceForTestRunner\n");
This looks like debug code that should not be committed.
> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:265
> + fprintf(stderr, "Set CSSTypedOMEnabled\n");
ditto
More information about the webkit-reviews
mailing list