[webkit-reviews] review granted: [Bug 191356] Be strict on request's Content-Type : [Attachment 374569] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 13:32:24 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 191356: Be strict on request's Content-Type
https://bugs.webkit.org/show_bug.cgi?id=191356

Attachment 374569: Patch

https://bugs.webkit.org/attachment.cgi?id=374569&action=review




--- Comment #19 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374569
  --> https://bugs.webkit.org/attachment.cgi?id=374569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374569&action=review

> Source/WebCore/platform/network/HTTPParsers.cpp:161
> +static bool isCorsUnsafeRequestHeaderByte(const UChar c)

This function seems like excessive abstraction.  You could just put the values
in with containsCORSUnsafeRequestHeaderBytes


More information about the webkit-reviews mailing list