[webkit-reviews] review granted: [Bug 203152] Add partial TextSteam dumping for font-related classes : [Attachment 381303] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203152: Add partial TextSteam dumping for font-related classes
https://bugs.webkit.org/show_bug.cgi?id=203152

Attachment 381303: Patch

https://bugs.webkit.org/attachment.cgi?id=381303&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 381303
  --> https://bugs.webkit.org/attachment.cgi?id=381303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381303&action=review

> Source/WebCore/platform/graphics/Font.cpp:723
> +    // FIXME: dump more.

The used name, and postscript name are probably important to dump here. Can we
make this delegate to a platform-specific function, and have that one call
something like CTFontCopyAttribute(font.platformData.font(),
kCTFontNameAttribute) and CTFontCopyAttribute(font.platformData.font(),
kCTFontFamilyNameAttribute)?

Also, m_isInterstitial would be valuable to know, and
font.platformData().syntheticBold() and  font.platformData().syntheticOblique()