[webkit-reviews] review granted: [Bug 199070] [WinCairo][PlayStation] Add automation support for RemoteInspector SocketServer implementation. : [Attachment 381013] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 10:37:48 PDT 2019


Ross Kirsling <ross.kirsling at sony.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 199070: [WinCairo][PlayStation] Add automation support for RemoteInspector
SocketServer implementation.
https://bugs.webkit.org/show_bug.cgi?id=199070

Attachment 381013: PATCH

https://bugs.webkit.org/attachment.cgi?id=381013&action=review




--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 381013
  --> https://bugs.webkit.org/attachment.cgi?id=381013
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=381013&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.h:152
> +    void requestAutomationSession(const String& sessionID, const
Client::SessionCapabilities&);

Final nit: I guess the string name can be omitted here.


More information about the webkit-reviews mailing list