[webkit-reviews] review granted: [Bug 202980] [GTK][WPE] IconDatabase is not thread safe yet : [Attachment 380970] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 01:40:50 PDT 2019


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 202980: [GTK][WPE] IconDatabase is not thread safe yet
https://bugs.webkit.org/show_bug.cgi?id=202980

Attachment 380970: Patch

https://bugs.webkit.org/attachment.cgi?id=380970&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 380970
  --> https://bugs.webkit.org/attachment.cgi?id=380970
Patch

Patch LGTM. Given that all the uses of the database (“m_db” member)
are done in the work queue thread, maybe it would be a good thing
to add “ASSERT(!isMainThread())” at the top of helper functions
like “IconDatabase::createTablesIfNeeded()” to make it clearer that
they are not intended to be used directly from the main thread, WDYT?


More information about the webkit-reviews mailing list