[webkit-reviews] review granted: [Bug 202650] Throw the right exception upon memory exhaustion in Array::slice : [Attachment 380462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 20 21:58:37 PDT 2019


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 202650: Throw the right exception upon memory exhaustion in Array::slice
https://bugs.webkit.org/show_bug.cgi?id=202650

Attachment 380462: Patch

https://bugs.webkit.org/attachment.cgi?id=380462&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 380462
  --> https://bugs.webkit.org/attachment.cgi?id=380462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380462&action=review

> Source/JavaScriptCore/runtime/ArrayBuffer.cpp:298
> +RefPtr<ArrayBuffer> ArrayBuffer::slice(double begin, double end) const

Do callers of these various functions check for exceptions?


More information about the webkit-reviews mailing list