[webkit-reviews] review granted: [Bug 203177] [JSC] DFG::CommonData modification by DFG reallyAdd should be guarded by CodeBlock's lock : [Attachment 381356] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 203177: [JSC] DFG::CommonData modification by DFG reallyAdd should be
guarded by CodeBlock's lock
https://bugs.webkit.org/show_bug.cgi?id=203177

Attachment 381356: Patch

https://bugs.webkit.org/attachment.cgi?id=381356&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 381356
  --> https://bugs.webkit.org/attachment.cgi?id=381356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381356&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGDesiredGlobalProperties.cpp:69
> +	   watchpointSet.add(watchpoint);

Why not WTFMove(watchpoint) here too?

> JSTests/stress/dfg-really-add-locking.js:1
> +//@ runDefault("--collectContinuously=1", "--useGenerationalGC=0")

How long does this test take to run?  if it's a slow test, then consider adding
"//@ slow!" here too.