[webkit-reviews] review granted: [Bug 203175] macCatalyst: Cursor should send mouse events, not touch events : [Attachment 381358] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 203175: macCatalyst: Cursor should send mouse events, not touch events
https://bugs.webkit.org/show_bug.cgi?id=203175

Attachment 381358: Patch

https://bugs.webkit.org/attachment.cgi?id=381358&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381358
  --> https://bugs.webkit.org/attachment.cgi?id=381358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381358&action=review

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:57
> +    Optional<WebKit::NativeWebMouseEvent> _lastEvent;

std::unique_ptr<>?

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:146
> +    auto timestamp = WallTime::fromRawSeconds(GSCurrentEventTimestamp() /
1000000000.0);

Don't we have a nanosecondsToMumble?