[webkit-reviews] review granted: [Bug 203147] [WebAuthn] Warn users when no credentials are found : [Attachment 381334] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 203147: [WebAuthn] Warn users when no credentials are found
https://bugs.webkit.org/show_bug.cgi?id=203147

Attachment 381334: Patch

https://bugs.webkit.org/attachment.cgi?id=381334&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 381334
  --> https://bugs.webkit.org/attachment.cgi?id=381334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381334&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:248
> +    if (auto *panel = m_pendingRequestData.panel.get())

auto* panel
This isn't an Objective C file... but is this an ObjC data type?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:58
> +	   return;

This 'return' isn't really needed.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:92
> +    RetainPtr<NSObject <_WKWebAuthenticationPanelDelegate>> _delegate;

The whitespace between NSObject and < is not needed.