[webkit-reviews] review canceled: [Bug 203164] Web Inspector: Provide a flag for technology preview builds : [Attachment 381327] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 18 14:33:20 PDT 2019
Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 203164: Web Inspector: Provide a flag for technology preview builds
https://bugs.webkit.org/show_bug.cgi?id=203164
Attachment 381327: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=381327&action=review
--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 381327
--> https://bugs.webkit.org/attachment.cgi?id=381327
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=381327&action=review
>> Source/WebCore/inspector/InspectorFrontendHost.idl:86
>> + boolean isExperimentalBuild();
>
> Why not `readonly attribute boolean isExperimentalBuild`, similar to
`isRemote`?
They could both be booleans, I was just following the existing convention here.
I don't think there is an advantage to either, so I'll keep these aligned.
More information about the webkit-reviews
mailing list