[webkit-reviews] review granted: [Bug 191523] [WebAuthn] Implement AuthenticatorCancel : [Attachment 381319] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 191523: [WebAuthn] Implement AuthenticatorCancel
https://bugs.webkit.org/show_bug.cgi?id=191523

Attachment 381319: Patch

https://bugs.webkit.org/attachment.cgi?id=381319&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 381319
  --> https://bugs.webkit.org/attachment.cgi?id=381319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381319&action=review

Looks good! r=me

> Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp:104
> +    memset(serialized.data() + offset, 0, kHidPacketSize - offset);

Yes, this looks much better.

> Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp:154
> +    memset(serialized.data() + offset, 0, kHidPacketSize - offset);

Ditto.