[webkit-reviews] review granted: [Bug 202964] Integrate resize event with HTML5 event loop : [Attachment 381197] Windows test fix attempt

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 202964: Integrate resize event with HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=202964

Attachment 381197: Windows test fix attempt

https://bugs.webkit.org/attachment.cgi?id=381197&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 381197
  --> https://bugs.webkit.org/attachment.cgi?id=381197
Windows test fix attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=381197&action=review

r=me

> Source/WebCore/page/Page.cpp:1297
> +    layoutIfNeeded();

Are the additional layoutIfNeeded() calls below also required? (Kind of sad to
do up to three layouts just because certain events dirtied the DOM.)

> Source/WebCore/page/Page.cpp:2879
> +	   auto* document = frame->document();
> +	   if (!document)
> +	       continue;

A frame always has a document, so you can skip this null check.