[webkit-reviews] review granted: [Bug 203125] Only include "deep color" in layer tree dumps if a tests requests it : [Attachment 381243] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203125: Only include "deep color" in layer tree dumps if a tests requests
it
https://bugs.webkit.org/show_bug.cgi?id=203125

Attachment 381243: Patch

https://bugs.webkit.org/attachment.cgi?id=381243&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 381243
  --> https://bugs.webkit.org/attachment.cgi?id=381243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381243&action=review

> Source/WebCore/testing/Internals.h:374
> +	   LAYER_TREE_INCLUDES_DEEP_COLOR = 1024,

Why is this not bit shifts!

> Source/WebCore/testing/Internals.idl:401
> +    const unsigned short LAYER_TREE_INCLUDES_DEEP_COLOR = 1024;

Maybe this is why