[webkit-reviews] review granted: [Bug 203044] Load event must be fired only for the SVG structurally external elements and the outermost SVG element : [Attachment 381235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 17 15:41:07 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 203044: Load event must be fired only for the SVG structurally external
elements and the outermost SVG element
https://bugs.webkit.org/show_bug.cgi?id=203044

Attachment 381235: Patch

https://bugs.webkit.org/attachment.cgi?id=381235&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381235
  --> https://bugs.webkit.org/attachment.cgi?id=381235
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381235&action=review

> Source/WebCore/svg/SVGScriptElement.h:76
> +    Timer* loadEventTimer() final { return &m_loadEventTimer; }

Seems weird to expose the timer outside the class. Does anyone use it?


More information about the webkit-reviews mailing list