[webkit-reviews] review granted: [Bug 203023] Make requestIdleCallback suspendable : [Attachment 381159] Fixed the test for ToT

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 203023: Make requestIdleCallback suspendable
https://bugs.webkit.org/show_bug.cgi?id=203023

Attachment 381159: Fixed the test for ToT

https://bugs.webkit.org/attachment.cgi?id=381159&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 381159
  --> https://bugs.webkit.org/attachment.cgi?id=381159
Fixed the test for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=381159&action=review

r=me

> Source/WebCore/dom/WindowEventLoop.cpp:84
> +    for (auto& task : m_tasks)

remainingTasks.appendVector(m_tasks); would be more concise and likely more
efficient.

> Source/WebCore/dom/WindowEventLoop.h:69
> +    Vector<Task> m_suspendedTasks;

This appears to be unused?