[webkit-reviews] review granted: [Bug 202815] [FTW] Correct radial gradient handling of various radius orderings : [Attachment 381138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 16 18:08:07 PDT 2019


Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 202815: [FTW] Correct radial gradient handling of various radius orderings
https://bugs.webkit.org/show_bug.cgi?id=202815

Attachment 381138: Patch

https://bugs.webkit.org/attachment.cgi?id=381138&action=review




--- Comment #24 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 381138
  --> https://bugs.webkit.org/attachment.cgi?id=381138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381138&action=review

R=me.

> Source/WebCore/platform/graphics/win/GradientDirect2D.cpp:147
> +	       if (!circleIsEntirelyContained(data.point0, data.startRadius,
data.point1, data.endRadius))
> +		   offset = (data.point1.scaled(data.startRadius) -
data.point0.scaled(data.endRadius)) / (data.endRadius - data.startRadius);

Why was this check needed? Did adding this check fix more tests?


More information about the webkit-reviews mailing list